Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the NetworkErrorReconciler to our controllers #1076

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

tomkennedy513
Copy link
Collaborator

No description provided.

Copy link
Contributor

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1076 (b788e78) into main (9593d3c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
- Coverage   70.48%   70.29%   -0.19%     
==========================================
  Files         123      123              
  Lines        6061     6077      +16     
==========================================
  Hits         4272     4272              
- Misses       1380     1396      +16     
  Partials      409      409              
Impacted Files Coverage Δ
pkg/reconciler/builder/builder.go 41.66% <0.00%> (-2.46%) ⬇️
pkg/reconciler/clusterbuilder/clusterbuilder.go 41.66% <0.00%> (-2.46%) ⬇️
pkg/reconciler/clusterstack/clusterstack.go 51.61% <0.00%> (-3.56%) ⬇️
pkg/reconciler/clusterstore/clusterstore.go 51.61% <0.00%> (-3.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomkennedy513 tomkennedy513 merged commit a4b87c8 into main Nov 22, 2022
@tomkennedy513 tomkennedy513 deleted the reimplement-network-error-reconciler branch November 22, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants