Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parsed ssh username if git2go does not provide one #1121

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

tomkennedy513
Copy link
Collaborator

@tomkennedy513 tomkennedy513 commented Jan 19, 2023

This is required because git2go is unable to parse the username when calling remote.Fetch with the go ssh transport

@codecov-commenter
Copy link

Codecov Report

Merging #1121 (be3f613) into main (3e3e489) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   69.85%   69.97%   +0.12%     
==========================================
  Files         124      124              
  Lines        6193     6219      +26     
==========================================
+ Hits         4326     4352      +26     
  Misses       1462     1462              
  Partials      405      405              
Impacted Files Coverage Δ
pkg/git/git_keychain.go 82.43% <100.00%> (+0.48%) ⬆️
pkg/apis/build/v1alpha1/builder_validation.go 100.00% <0.00%> (ø)
pkg/apis/build/v1alpha2/builder_validation.go 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chenbh chenbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add either a code comment or commit message that explains the rationale behind this change? I fear the context is going to be lost especially since we don't have an issue explaining the problem.

- This is required because git2go is unable to parse the username when
  calling remote.Fetch with the go ssh transport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants