Improve the error message when source resolver is not resolving #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yael Harel <yharel@vmware.com>
yaelharel
requested review from
matthewmcnew,
tomkennedy513,
chenbh and
ncarlson
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
+ Coverage 70.25% 70.27% +0.01%
==========================================
Files 124 124
Lines 6219 6223 +4
==========================================
+ Hits 4369 4373 +4
Misses 1445 1445
Partials 405 405
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
March 7, 2023 15:09
Signed-off-by: Yael Harel <yharel@vmware.com>
Signed-off-by: Yael Harel <yharel@vmware.com>
ncarlson
reviewed
Mar 9, 2023
pkg/reconciler/image/image_test.go
Outdated
| Type: buildapi.ConditionSourceResolverReady, | ||
| Status: corev1.ConditionFalse, | ||
| Reason: buildapi.SourceResolverNotReady, | ||
| Message: "SourceResolver image-name-source is not ready: something is failing", |
Signed-off-by: Yael Harel <yharel@vmware.com>
Signed-off-by: Yael Harel <yharel@vmware.com>
chenbh
approved these changes
Mar 10, 2023
ncarlson
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.