Bump cosign to v2 and use new APIs #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
ThomasVitale
requested review from
matthewmcnew,
tomkennedy513,
chenbh,
yaelharel and
pviraj59
as code owners
|
Hi @ThomasVitale Thank you for the pr! It looks like there are some failing tests. Would you be able to take a look at those? |
|
@tomkennedy513 I'm looking into the failing tests and will update the PR asap. Thanks! |
Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
|
@tomkennedy513 tests updated |
Codecov Report
@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 67.58% 67.59% +0.01%
==========================================
Files 132 132
Lines 7999 8002 +3
==========================================
+ Hits 5406 5409 +3
Misses 2164 2164
Partials 429 429
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ThomasVitale
commented
May 2, 2023
tomkennedy513
approved these changes
May 3, 2023
chenbh
approved these changes
May 3, 2023
| false, | ||
| false, | ||
| "", | ||
| true); err != nil { |
There was a problem hiding this comment.
Nice catch on the flipping of noTlogUpload -> TlogUpload!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1182