Add support for known_hosts file #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we switched from libgit2 to go-git, the ssh source was broken because libgit2 implicitly trusted unknown hosts whereas go-git required it to be explicitly done in code. this commit fixes that regression by introducing a flag on the controller to explicitly trust all unknown hosts. at the same time, we also introduce the ability to specify the trusted hosts via the git ssh secret. Signed-off-by: Bohan Chen <bohanc@vmware.com>
for use cases like the source resolver controller where we have access to the value in memory instead of as a file Signed-off-by: Bohan Chen <bohanc@vmware.com>
Signed-off-by: Bohan Chen <bohanc@vmware.com>
chenbh
requested review from
matthewmcnew,
tomkennedy513 and
pviraj59
as code owners
| @@ -11,7 +11,6 @@ import ( | |||
| ggcrv1 "github.com/google/go-containerregistry/pkg/v1" | |||
| "github.com/pkg/errors" | |||
| corev1 "k8s.io/api/core/v1" | |||
| v1 "k8s.io/api/core/v1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1230
For more details see the docs change
INSECURE_SSH_TRUST_UNKNOWN_HOSTSto automatically trust unknown hosts (default value istrueto keep backwards compatibiltyknown_hostsfield can be specified on the ssh auth secret to configure it