Issue 1094 improve error handling #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fcaroline2020
commented
Aug 16, 2023
•
fcaroline2020
commented
- Updates error messages to follow the format "Error: occurence (1) component 'component_name' (2) in namespace 'namespace_name' (3) : additional info (4).
- Fixes https://github.com/pivotal/build-service/issues/1020
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1302 +/- ##
==========================================
- Coverage 67.75% 67.74% -0.02%
==========================================
Files 132 132
Lines 8067 8069 +2
==========================================
Hits 5466 5466
- Misses 2171 2173 +2
Partials 430 430
|
sambhav
approved these changes
Aug 17, 2023
improves "lifecycle image has not been loaded" error message to include configmap name and location Clarify error if clusterstack is not ready Fix failing unit test
fcaroline2020
force-pushed
the
issue-1094-improve-error-handling
branch
from
335f7c2 to
0db16f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.