Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates pr-1309 with code improvements suggested by Daniel Chen #1316

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Updates pr-1309 with code improvements suggested by Daniel Chen #1316

merged 1 commit into from
Aug 30, 2023

Conversation

fcaroline2020
Copy link
Contributor

  • toss the error from func 'waitBuild' up the chain instead of trying to handle it in wait_for_image
  • remove else from func 'waitBuild'
  • use 'buildFailure' func to format error message

@fcaroline2020 fcaroline2020 requested a review from a team as a code owner August 30, 2023 09:53
@fcaroline2020
Copy link
Contributor Author

@chenbh

@chenbh chenbh merged commit 2245aa6 into main Aug 30, 2023
@chenbh chenbh deleted the pr-1309-improvements branch August 30, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenbh chenbh chenbh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcaroline2020 @chenbh