Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve submodule support #1361

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Improve submodule support #1361

merged 5 commits into from
Oct 26, 2023

Conversation

tomkennedy513
Copy link
Collaborator

Add submodule configuration to git source config

Signed-off-by: Tom Kennedy <ktom@vmware.com>
Signed-off-by: Tom Kennedy <ktom@vmware.com>
Signed-off-by: Tom Kennedy <ktom@vmware.com>
@tomkennedy513 tomkennedy513 marked this pull request as ready for review October 24, 2023 14:31
@tomkennedy513 tomkennedy513 requested a review from a team as a code owner October 24, 2023 14:31
docs/image.md Outdated Show resolved Hide resolved
pkg/apis/build/v1alpha2/build_pod_test.go Outdated Show resolved Hide resolved
- Also update docs

Signed-off-by: Tom Kennedy <ktom@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1361 (0d97dd2) into main (4bbd92e) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   67.29%   67.30%   +0.01%     
==========================================
  Files         133      133              
  Lines        8224     8228       +4     
==========================================
+ Hits         5534     5538       +4     
  Misses       2237     2237              
  Partials      453      453              
Files Coverage Δ
pkg/apis/build/v1alpha2/build_types.go 100.00% <ø> (ø)
pkg/apis/build/v1alpha2/image_types.go 50.00% <ø> (ø)
pkg/git/remote_git_resolver.go 95.91% <100.00%> (+0.26%) ⬆️
pkg/git/fetch.go 59.25% <46.15%> (+0.50%) ⬆️

Signed-off-by: Tom Kennedy <ktom@vmware.com>
@tomkennedy513 tomkennedy513 merged commit 0c8643c into main Oct 26, 2023
2 checks passed
@tomkennedy513 tomkennedy513 deleted the submodule-support branch October 26, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants