-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Support #546
Windows Support #546
Conversation
e28bb30
to
498f98c
Compare
e8f7c16
to
eefb495
Compare
@@ -3,7 +3,9 @@ | |||
controller_image: gcr.io/controller | |||
webhook_image: gcr.io/webhook | |||
build_init_image: gcr.io/build-init | |||
build_init_windows_image: gcr.io/cf-build-service-public/kpack/build-init-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the expectation that this is built/updated out of band of ./hack/release.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, at least for now. Maybe in the future we could conceivably build the images using something other than pack that could run on linux and still build the windows images
bf6967e
to
357febe
Compare
What are are remaining issues with Windows?
|
1dc33c8
to
2729e9a
Compare
- wait for dns on windows. This is dues to the fact that windows containers on docker don't start up without their network ready so we have to wait. we think that this can be removed when containerd is the default runtime. In the build-init binary we don't error on timeout because we assume that it timed out due to an incorrect host, so we want the normal error for that to still apply. - create network wait launcher binary. This is used to execute the lifecycle containers during the build after the network is ready in windows containers. it is built with build-init and copied to a shared volume during the prepare step. we also think this can be removed when containerd is the default runtime - Copy git repository to workspace directory becase clone directly to workspace was causing issues on Windows - add os to builder status - Update openapi spec with latest openapi gen binary - add windows images to controller yaml - caching is not currently implemented for windows builds because the DefaultStorageClass isn't always compatible with windows. This will require more investigation Co-authored-by: Tom Kennedy <ktom@vmware.com> Co-authored-by: Anthony Emengo <aemengo@vmware.com> Co-authored-by: Matthew McNew <mmcnew@pivotal.io>
2729e9a
to
f3eb817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work!
No description provided.