Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce download-sbom docs #457

Closed
wants to merge 5 commits into from

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented Jan 5, 2022

Resolves: #455

Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice feature overview. I've tried to simplify one paragraph. I'm trying to make it more difficult to misinterpret and removing references to other features such as "layers". Do we need the reader to understand what a layer is in order to understand that pack offers an sbom-download feature?

content/docs/features/bill-of-materials.md Outdated Show resolved Hide resolved
content/docs/features/bill-of-materials.md Outdated Show resolved Hide resolved
content/docs/features/bill-of-materials.md Outdated Show resolved Hide resolved
Anthony Emengo added 2 commits January 21, 2022 10:49
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
* Make statements less difficult to misinterpret
  Thanks for the PR Review: @AidanDelaney

Signed-off-by: Anthony Emengo <aemengo@vmware.com>
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changing the command name to pack sbom download

content/docs/features/bill-of-materials.md Outdated Show resolved Hide resolved
content/docs/features/bill-of-materials.md Outdated Show resolved Hide resolved
content/docs/features/bill-of-materials.md Outdated Show resolved Hide resolved
@samj1912
Copy link
Member

@AidanDelaney would you be able to take over this PR and drive it to completion?

@AidanDelaney
Copy link
Member

Closing this PR as I can't push changes to the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update outdated BOM content
3 participants