Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and expand on implications of upgrading to Platform API 0.10 #617

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

natalieparellano
Copy link
Member

No description provided.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner September 20, 2023 21:31
@@ -22,7 +22,7 @@ Hand-in-hand with shell removal is the introduction of overridable process argum

In `launch.toml`, `command` is now a list. The first element in `command` is the command, and all following entries are arguments that are always provided to the process, regardless of how the application is started. The `args` list now designates arguments that can be overridden by the end user - if supported by the platform (Platform API version 0.10 and above). For further details, see the platform [migration guide](/docs/reference/spec/migration/platform-api-0.9-0.10).

For older platforms (Platform API version 0.9 and below), arguments in `args` will be appended to arguments in `command`, negating the new functionality (but preserving compatibility).
For older platforms (Platform API version 0.9 and below), arguments in `command` will be prepended to arguments in `args`, negating the new functionality (but preserving compatibility).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Means the same thing but is more accurate

@@ -51,7 +63,7 @@ args = ["always-1", "always-2"]
The `command` list will never have more than one element. `always-1` and `always-2` are arguments that are always provided to `some-command`. If no user-provided arguments are specified when the application image is launched, `always-1` and `always-2` will be provided only. If user-provided arguments are specified, these will be **appended** to the `args` list. Example:

```
docker run --entrypoint from-newer-buildpack my-image
docker run --entrypoint from-older-buildpack my-image
Copy link
Member Author

@natalieparellano natalieparellano Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing an oops

Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AidanDelaney AidanDelaney merged commit 7c5f256 into main Nov 30, 2023
1 check passed
@AidanDelaney AidanDelaney deleted the update-migration branch November 30, 2023 17:42
github-actions bot pushed a commit that referenced this pull request Nov 30, 2023
Clarify and expand on implications of upgrading to Platform API 0.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants