Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the landing page #719

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

hyounes4560
Copy link
Contributor

Changes the location of the talks section from the landing page
Adds an overview paragraph to the landing page
Updates the level of few section headings in the Getting Started landing page
Changes the order of talks by time
Other minor edits

Changes the order of talks by time

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 requested a review from a team as a code owner June 2, 2024 05:16
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 mentioned this pull request Jun 2, 2024
4 tasks
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggested change. Otherwise, LGTM!

content/docs/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks for doing this @hyounes4560 🙏🏼

hyounes4560 and others added 2 commits June 3, 2024 22:57
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@AidanDelaney
Copy link
Member

I've manually reviewed the DCO. Everything looks fine to me. I'm not sure why our DCO check is failing to return. We're using the DCO app at https://probot.github.io/apps/dco/

@AidanDelaney AidanDelaney merged commit 3ec1c78 into buildpacks:main Jun 4, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
* Updates the landing page
Changes the order of talks by time

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* fixes a broken link

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* fixes the community page link

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* adds reviewers' feedback

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

---------

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 deleted the update-index-page branch June 5, 2024 02:06
github-actions bot pushed a commit to hyounes4560/docs that referenced this pull request Jun 5, 2024
* Updates the landing page
Changes the order of talks by time

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* fixes a broken link

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* fixes the community page link

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* adds reviewers' feedback

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

---------

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants