Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document image labels #734

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Document image labels #734

merged 3 commits into from
Jun 20, 2024

Conversation

hyounes4560
Copy link
Contributor

  • Document image labels
  • Edits the exec.d page

Closes #733

@hyounes4560
updates the exec.d docs
da8b4ff 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
adds image labels info
77199f0 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 requested a review from a team as a code owner June 19, 2024 05:22
@hyounes4560
Copy link
Contributor Author

@AidanDelaney content esp. examples might need an update.

AidanDelaney
AidanDelaney requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some very strong contributions here. We need only clean up some of the technical language around how labels are implemented according to the buildpacks spec.

content/docs/for-buildpack-authors/how-to/write-buildpacks/add-labels.md Show resolved Hide resolved
content/docs/for-buildpack-authors/how-to/write-buildpacks/add-labels.md Outdated Show resolved Hide resolved
content/docs/for-buildpack-authors/how-to/write-buildpacks/add-labels.md Outdated Show resolved Hide resolved
content/docs/for-buildpack-authors/how-to/write-buildpacks/add-labels.md Outdated Show resolved Hide resolved
content/docs/for-buildpack-authors/how-to/write-buildpacks/use-exec.d.md Show resolved Hide resolved
@hyounes4560
adds reviewers feedback
3c70136 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
AidanDelaney
AidanDelaney approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AidanDelaney AidanDelaney merged commit 9fd960c into buildpacks:main Jun 20, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@AidanDelaney
Document image labels (#734)
2ce0036 
* updates the exec.d docs

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* adds image labels info

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

* adds reviewers feedback

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>

---------

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@natalieparellano
Copy link
Member

Just catching up here. Awesome work @hyounes4560!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanDelaney AidanDelaney AidanDelaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add content to the "Add labels to the application image" page
3 participants
@hyounes4560 @natalieparellano @AidanDelaney