Expand buildpack author concepts pages #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
|
@AidanDelaney @natalieparellano still waiting for your review? Thanks |
AidanDelaney
requested changes
Jul 6, 2024
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
There was a problem hiding this comment.
Amazing work @hyounes4560! It's really cool to see this coming along. I left some comments and some longer explanations where we could flesh things out more. LMK what you think!
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
content/docs/for-buildpack-authors/concepts/component-buildpack.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
* adds some build plan content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * edits MD styling Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds component buildpack content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds some dependency layer content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds buildpack package content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds reviewer feedback Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds 2nd reviewer feedback Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * Adds some links Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * updates dependency layer page Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds pages linking Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> * adds more build-plan and layers content Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> --------- Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com> Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand buildpack author concepts pages
exec.d page
closes #740