Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding version to buildpacks/github-actions/setup-pack #38

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

jonashackt
Copy link
Contributor

Fixes #37

Using the pinned version my build https://github.com/jonashackt/spring-boot-buildpack/runs/2146471906?check_suite_focus=true worked as expected.

Using only the @v4 resulted in the following error:

Error: Unable to resolve action `buildpacks/github-actions@v4`, unable to find version `v4`

@jonashackt jonashackt requested a review from a team as a code owner March 19, 2021 07:42
@jkutner jkutner mentioned this pull request Mar 19, 2021
@jkutner
Copy link
Member

jkutner commented Mar 19, 2021

@jonashackt thanks! I know this is a pain to ask, but if you can DCO sign-off this commit, I can merge it (you'll have to pull the jonashackt:patch-1 branch or create a new one). If you don't care about getting a commit with your user into the repo, I can merge #39

See buildpacks#37. Using the pinned version my build https://github.com/jonashackt/spring-boot-buildpack/runs/2146471906?check_suite_focus=true worked as expected. Using only the `@v4` resulted in [the following error](https://github.com/jonashackt/spring-boot-buildpack/runs/2146458399?check_suite_focus=true):
```
Error: Unable to resolve action `buildpacks/github-actions@v4`, unable to find version `v4`
```

Signed-off-by: Jonas Hecht <jonas.hecht@codecentric.de>
@jonashackt
Copy link
Contributor Author

@jkutner done - sorry for the delay. DCO bot looks good now :) Interesting tooling! Need to have a look.

@jkutner jkutner added type:documentation A documentation update semver:patch A change requiring a patch version bump labels Mar 23, 2021
@jkutner
Copy link
Member

jkutner commented Mar 23, 2021

@jonashackt thanks!

@jkutner jkutner merged commit 5609f7e into buildpacks:main Mar 23, 2021
@jonashackt jonashackt deleted the patch-1 branch March 24, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action version missing in docs: The workflow is not valid. Expected format {org}/{repo}[/path]@ref.
2 participants