Add a test to check that providing the insecure registry settings it

pulls the remote image from the insecure registry as well

Signed-off-by: Domenico Luciani <dluciani@vmware.com>

remote/options.go

@@ -99,6 +99,7 @@ func WithPreviousImage(imageName string) ImageOption {
 // the image. The referenced images could include the base image, a previous image, or the image itself.
 func WithRegistrySetting(repository string, insecure, insecureSkipVerify bool) ImageOption {
 	return func(opts *options) error {
+		opts.registrySettings = make(map[string]registrySetting)
 		opts.registrySettings[repository] = registrySetting{
 			insecure:           insecure,
 			insecureSkipVerify: insecureSkipVerify,

remote/remote_test.go

@@ -201,6 +201,15 @@ func testImage(t *testing.T, when spec.G, it spec.S) {
 						h.AssertNil(t, err)
 						defer readCloser.Close()
 					})
+					it("try to pull the image from an insecure registry if WithRegistrySettings insecure has been set", func() {
+						_, err := remote.NewImage(
+							repoName,
+							authn.DefaultKeychain,
+							remote.FromBaseImage("host.docker.internal/bar"),
+							remote.WithRegistrySetting("host.docker.internal", true, true))
+
+						h.AssertError(t, err, "http://")
+					})
 
 					it("sets the initial state from a windows/amd64 base image", func() {
 						baseImageName := "mcr.microsoft.com/windows/nanoserver@sha256:06281772b6a561411d4b338820d94ab1028fdeb076c85350bbc01e80c4bfa2b4"