Convert nested binding credentials to JSON #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modulo11
force-pushed
the
nested-bindings
branch
3 times, most recently
from
e2cdf83
to
c9eb483
Compare
pbusko
force-pushed
the
nested-bindings
branch
from
c9eb483
to
0f1a809
Compare
pbusko
force-pushed
the
nested-bindings
branch
2 times, most recently
from
582666e
to
3990a46
Compare
dmikusa
added
type:bug
dmikusa
reviewed
Sep 19, 2023
|
Looks good to me, just the one suggestion with the test. |
pbusko
force-pushed
the
nested-bindings
branch
from
3990a46
to
92abc37
Compare
Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Signed-off-by: Johannes Dillmann <j.dillmann@sap.com> Signed-off-by: Pavel Busko <pavel.busko@sap.com>
pbusko
force-pushed
the
nested-bindings
branch
from
92abc37
to
f322935
Compare
dmikusa
approved these changes
Sep 21, 2023
c0d1ngm0nk3y
pushed a commit
to sap-contributions/libcnb
that referenced
this pull request
Oct 12, 2023
Signed-off-by: Johannes Dillmann <j.dillmann@sap.com> Signed-off-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
c0d1ngm0nk3y
pushed a commit
to sap-contributions/libcnb
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Johannes Dillmann <j.dillmann@sap.com> Signed-off-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com>
dmikusa
pushed a commit
that referenced
this pull request
Oct 23, 2023
Convert nested binding credentials to JSON (#256) Signed-off-by: Johannes Dillmann <j.dillmann@sap.com> Signed-off-by: Pavel Busko <pavel.busko@sap.com> Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Johannes Dillmann <modulo11@users.noreply.github.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254.
Fix swallowing the parsing error and marshal properties to JSON if they are not a string.