Exporter changes for run image extension #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The logic to update the default path for TOML files was repeated across phases - In general it is safe to provide default values for inputs that might not be relevant to the current phase, as these will be ignored when constructing a new service for the phase; e.g., platform.LifecycleInputs.OrderPath will be ignored when constructing a lifecycle.Exporter - As more inputs are shared across phases (e.g., analyzed.toml is now an input to the detect phase), duplicating the logic for providing default values is becoming more cumbersome Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…= 0.10 Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…kage Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
… the platform spec Signed-off-by: Natalie Arellano <narellano@vmware.com>
…mage.extend = <true or false, default false> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
… should fail if the selected base image is not found in run.toml. Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
- digest ref for run image - target data for run image Additionally the restorer will download the run image manifest & config when extend is true Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Because we change the media types to be oci types (vs docker types) this changes the digest of the image Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
imgutil/layout/sparse modifies the image media types which we don't want Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
| // WithBase if populated indicates that the Dockerfile switches the image base to the provided value. | ||
| // If WithBase is empty, Extend should be true, otherwise there is nothing for the Dockerfile to do. | ||
| // However if WithBase is populated, Extend may be true or false. | ||
| WithBase string |
There was a problem hiding this comment.
For some reason WithBase seemed more clear than NewBase. But we can change it back if that's not true
There was a problem hiding this comment.
Comment on lines
+127
to
+128
| // We need to create the temp directory before `it.Before` blocks because we want the variable to be populated | ||
| // when we set up the table tests. |
| @@ -246,7 +246,7 @@ func testExporter(t *testing.T, when spec.G, it spec.S) { | |||
| }) | |||
| }) | |||
|
|
|||
| it("creates app layer on Run image", func() { | |||
| it("creates app layer on run image", func() { | |||
There was a problem hiding this comment.
This PR obviously needs some more unit tests 🙃
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Instead of hard-coding the run image and run image top layer SHAs, we can derive their values Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
runext/export-999
branch
from
96e6deb
to
00938a2
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
runext/export-999
branch
from
1aadde7
to
9acea63
Compare
jabrown85
approved these changes
Apr 13, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Co-authored-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #999
Also fixes some issues with other phases found during demo testing