Target envvars #1078
Merged
Target envvars #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-kimmel-vmw
force-pushed
the
target_envvars
branch
from
72faf8f
to
c5debb3
Compare
2 tasks
joe-kimmel-vmw
force-pushed
the
target_envvars
branch
from
eedaf8f
to
b5bfb40
Compare
- allowed to be passed through in the env vars allow-list - threaded through builder - threaded through detector - threaded through generator Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
target_envvars
branch
from
b5bfb40
to
869e013
Compare
| @@ -22,14 +22,12 @@ type buildCmd struct { | |||
| // DefineFlags defines the flags that are considered valid and reads their values (if provided). | |||
| func (b *buildCmd) DefineFlags() { | |||
| switch { | |||
| case b.PlatformAPI.AtLeast("0.12"): | |||
| cli.FlagAnalyzedPath(&b.AnalyzedPath) | |||
| fallthrough | |||
There was a problem hiding this comment.
Nice improvement, thanks :)
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
|
Thanks @natalieparellano - but also, gross - my apologies for missing all those commented lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.