Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated buildpack APIs #1148

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano force-pushed the remove-deprecated-buildpack branch 5 times, most recently from 9f61eeb to 71f9dda Compare July 12, 2023 18:07
…cks/rfcs/blob/main/text/0110-deprecate-apis.md

- Fix acceptance by updating fixtures to use newer Buildpack API version

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano marked this pull request as ready for review July 13, 2023 14:24
@natalieparellano natalieparellano requested a review from a team as a code owner July 13, 2023 14:24
Copy link
Contributor

@jabrown85 jabrown85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much code deleted ❤️ 😮

Left a couple questions

cmd/lifecycle/main.go Outdated Show resolved Hide resolved
cmd/launcher/cli/launcher.go Outdated Show resolved Hide resolved
@natalieparellano natalieparellano added this to the lifecycle 0.18.0 milestone Aug 3, 2023
@natalieparellano natalieparellano merged commit a12fbff into main Aug 23, 2023
7 checks passed
@natalieparellano natalieparellano deleted the remove-deprecated-buildpack branch August 23, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants