Fix regression in Platform API 0.10 #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toml after generate Platform 0.10 expects to find the reference in analyzed.toml Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/platform-010
branch
from
00bdf85
to
2529710
Compare
jabrown85
approved these changes
Oct 3, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In lifecycle 0.17.0 we stopped writing
referencein analyzed.toml during the generate phase when the run image was switched by extensions. This is because the restorer would "always" take the run imageimageand turn it into areference. However the restorer was only doing this for Platform API 0.12 and above.[run-image.image]isn't a thing in Platform API 0.10 so we have to write the image from extensions intoreferenceand overwrite it with a real reference during restore.Release notes
Fixes regression in Platform API 0.10 by writing
referencein analyzed.toml during the generate phase when the run image was switched by extensionsRelated
Resolves #___
Context