Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned deps #1280

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Update pinned deps #1280

merged 1 commit into from
Feb 5, 2024

Conversation

natalieparellano
Copy link
Member

We can remove docker & containerd pins:

  • Docker was pinned to 23.x because of kaniko, but now that kaniko has upgraded we can upgrade.
  • Containerd used to be pinned as a purely transitive dependency, but now that it has a require directive it should be okay to unpin it.

We can remove docker & containerd pins:
- Docker was pinned to 23.x because of kaniko,
  but now that kaniko has upgraded we can upgrade.
- Containerd used to be pinned as a purely transitive dependency,
  but now that it has a require directive it should be okay to unpin it.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner February 5, 2024 17:27
@natalieparellano natalieparellano mentioned this pull request Feb 5, 2024
@natalieparellano natalieparellano merged commit 751c7a2 into main Feb 5, 2024
10 checks passed
@natalieparellano natalieparellano deleted the update-deps branch February 5, 2024 17:52
modulo11 pushed a commit to sap-contributions/lifecycle that referenced this pull request Feb 9, 2024
We can remove docker & containerd pins:
- Docker was pinned to 23.x because of kaniko,
  but now that kaniko has upgraded we can upgrade.
- Containerd used to be pinned as a purely transitive dependency,
  but now that it has a require directive it should be okay to unpin it.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Johannes Dillmann <j.dillmann@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants