Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(updated with latest main) Allow setting environment variables using the build image #962

Merged
merged 4 commits into from
Nov 22, 2022
Merged

(updated with latest main) Allow setting environment variables using the build image #962

merged 4 commits into from
Nov 22, 2022

Conversation

natalieparellano
Copy link
Member

Supersedes #899

samj1912 and others added 3 commits August 29, 2022 18:45
@samj1912
Allow setting environment variables using the build image
27ddebe 
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@natalieparellano
Merge branch 'main' into builder-config
cd1f050
@natalieparellano
Add a few more unit tests
ddb46bf 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner November 22, 2022 17:16
@natalieparellano
Resolve absolute path of build config directory
ded4a7d 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #962 (ded4a7d) into main (532fc6c) will increase coverage by 0.05%.
The diff coverage is 72.12%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
+ Coverage   64.49%   64.54%   +0.05%     
==========================================
  Files          86       86              
  Lines        6175     6175              
==========================================
+ Hits         3982     3985       +3     
- Misses       1809     1813       +4     
+ Partials      384      377       -7
Flag Coverage Δ
os_linux 64.00% <72.12%> (+0.05%) ⬆️
os_windows 58.86% <36.00%> (+0.02%) ⬆️
unit 64.00% <72.12%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano natalieparellano mentioned this pull request Nov 22, 2022
Closed
samj1912
samj1912 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@samj1912 samj1912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@natalieparellano natalieparellano merged commit 4c62475 into main Nov 22, 2022
@natalieparellano natalieparellano deleted the builder-config branch November 22, 2022 22:21
@natalieparellano natalieparellano mentioned this pull request Dec 2, 2022
Open
7 tasks
@natalieparellano natalieparellano mentioned this pull request Jan 6, 2023
Closed
@Malax Malax mentioned this pull request Feb 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samj1912 samj1912 samj1912 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natalieparellano @samj1912