fixed mocks

Signed-off-by: Rashad Sirajudeen <rashadsirajudeen@gmail.com>
buildpacks · Jun 14, 2024 · c00a832 · c00a832
1 parent 0ccb347
commit c00a832
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 5 deletions.
diff --git a/internal/commands/build.go b/internal/commands/build.go
@@ -284,7 +284,6 @@ This option may set DOCKER_HOST environment variable for the build container if
 			cmd.Flags().MarkHidden("sparse")
 		}
 	}
-
 }
 
 func validateBuildFlags(flags *BuildFlags, cfg config.Config, inputImageRef client.InputImageReference, logger logging.Logger) error {

diff --git a/internal/commands/testmocks/mock_pack_client.go b/internal/commands/testmocks/mock_pack_client.go
diff --git a/internal/fakes/fake_lifecycle.go b/internal/fakes/fake_lifecycle.go
@@ -14,3 +14,8 @@ func (f *FakeLifecycle) Execute(ctx context.Context, opts build.LifecycleOptions
 	f.Opts = opts
 	return nil
 }
+
+func (f *FakeLifecycle) Detect(ctx context.Context, opts build.LifecycleOptions) error {
+	f.Opts = opts
+	return nil
+}
diff --git a/pkg/client/detect.go b/pkg/client/detect.go
@@ -3,8 +3,6 @@ package client
 import (
 	"context"
 	"fmt"
-
-	"github.com/docker/docker/api/types"
 )
 
 func (c *Client) Detect(ctx context.Context, opts BuildOptions) error {
@@ -13,8 +11,7 @@ func (c *Client) Detect(ctx context.Context, opts BuildOptions) error {
 		return err
 	}
 
-	defer c.docker.ImageRemove(context.Background(), lifecycleOpts.LifecycleImage, types.ImageRemoveOptions{Force: true})
-	defer c.docker.ImageRemove(context.Background(), lifecycleOpts.Builder.Name(), types.ImageRemoveOptions{Force: true})
+	// TODO: Cleanup
 
 	if err = c.lifecycleExecutor.Detect(ctx, *lifecycleOpts); err != nil {
 		return fmt.Errorf("executing detect: %w", err)