Address PR comments

- pack download-sbom -> pack sbom download ....
- Add warning message for pack inspect-image <> --bom

Signed-off-by: Anthony Emengo <aemengo@vmware.com>

cmd/cmd.go

@@ -79,7 +79,7 @@ func NewPackCommand(logger ConfigurableLogger) (*cobra.Command, error) {
 	rootCmd.AddCommand(commands.InspectImage(logger, imagewriter.NewFactory(), cfg, packClient))
 	rootCmd.AddCommand(commands.NewStackCommand(logger))
 	rootCmd.AddCommand(commands.Rebase(logger, cfg, packClient))
-	rootCmd.AddCommand(commands.DownloadSBOM(logger, packClient))
+	rootCmd.AddCommand(commands.NewSBOMCommand(logger, cfg, packClient))
 
 	rootCmd.AddCommand(commands.InspectBuildpack(logger, cfg, packClient))
 	rootCmd.AddCommand(commands.InspectBuilder(logger, cfg, packClient, builderwriter.NewFactory()))

internal/commands/download_sbom.go

@@ -20,11 +20,11 @@ func DownloadSBOM(
 ) *cobra.Command {
 	var flags DownloadSBOMFlags
 	cmd := &cobra.Command{
-		Use:     "download-sbom <image-name>",
+		Use:     "download <image-name>",
 		Args:    cobra.ExactArgs(1),
 		Short:   "Download SBoM from specified image",
 		Long:    "Download layer containing Structured Bill of Materials (SBoM) from specified image",
-		Example: "pack download-sbom buildpacksio/pack",
+		Example: "pack sbom download buildpacksio/pack",
 		RunE: logError(logger, func(cmd *cobra.Command, args []string) error {
 			if flags.Local && flags.Remote {
 				return errors.New("expected either '--local' or '--remote', not both")
@@ -39,7 +39,7 @@ func DownloadSBOM(
 			return client.DownloadSBOM(img, options)
 		}),
 	}
-	AddHelpFlag(cmd, "download-sbom")
+	AddHelpFlag(cmd, "download")
 	cmd.Flags().BoolVar(&flags.Local, "local", false, "Pull SBoM from local daemon (Default)")
 	cmd.Flags().BoolVar(&flags.Remote, "remote", false, "Pull SBoM from remote registry")
 	cmd.Flags().StringVar(&flags.DestinationDir, "output-dir", ".", "Path to export SBoM contents.\nIt defaults export to the current working directory.")

internal/commands/inspect_image.go

@@ -50,6 +50,10 @@ func InspectImage(
 			remote, remoteErr := client.InspectImage(img, false)
 			local, localErr := client.InspectImage(img, true)
 
+			if flags.BOM {
+				logger.Warn("Using the '--bom' flag with 'pack inspect-image <image-name>' is deprecated. Users are encouraged to use 'pack sbom download <image-name>'.")
+			}
+
 			if err := w.Print(logger, sharedImageInfo, local, remote, localErr, remoteErr); err != nil {
 				return err
 			}

internal/commands/sbom.go

@@ -0,0 +1,20 @@
+package commands
+
+import (
+	"github.com/spf13/cobra"
+
+	"github.com/buildpacks/pack/internal/config"
+	"github.com/buildpacks/pack/pkg/logging"
+)
+
+func NewSBOMCommand(logger logging.Logger, cfg config.Config, client PackClient) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "sbom",
+		Short: "Interact with SBoM",
+		RunE:  nil,
+	}
+
+	cmd.AddCommand(DownloadSBOM(logger, client))
+	AddHelpFlag(cmd, "sbom")
+	return cmd
+}