-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pack build should support --extension
#1551
Comments
Hi @natalieparellano, I would like to have a try at this issue. |
That is awesome @edithwuly! I can assign the issue to you if you like. In case it's helpful, here are a few relevant places in the code:
Please don't hesitate to reach out if you have any questions! |
Thanks @natalieparellano! It will be great if you could assign this issue to me. And the places you share are exactly what I'm looking for. I will let you know as soon as there is progress. |
Thanks a lot for helping us with this @edithwuly! |
Hi @natalieparellano, I have looking into the code and have some idea about what to do.
Is there anything wrong or missed? |
@edithwuly that looks right to me! For |
@natalieparellano sounds great! Thanks for your help! I'm working on it. |
Hi @natalieparellano! I have completed a simple version and proposed a PR. Please help me review, thanks! Besides, when developing, I have some questions:
|
@edithwuly thank you so much for the PR! I'll look this over tomorrow :) |
Description
Today you can run
pack build --buildpack
to dynamically add buildpacks to the builder and modify the order. It should be possible to add extensions in the same way.Proposed solution
--extension
s should always come firstorder-extensions
in order.toml) so we'll need to take that into accountThis should be blocked on pack should support- we can make a separate issue for extension packagespack extension *
commands #1470 (support forpack extension package
) as--extension
can accept a package inputAdditional context
The text was updated successfully, but these errors were encountered: