Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack should support pack extension * commands #1470

Closed
Tracked by #224
natalieparellano opened this issue Jun 23, 2022 · 9 comments · Fixed by #1603
Closed
Tracked by #224

pack should support pack extension * commands #1470

natalieparellano opened this issue Jun 23, 2022 · 9 comments · Fixed by #1603
Labels
good first issue A good first issue to get started with. status/blocked Issue or PR that is blocked. See comments. type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Jun 23, 2022

pack extension --help should show (analogously to pack buildpack --help):

  inspect     Show information about an extension
  package     Package an extension in OCI format. <- made a separate issue, please see https://github.com/buildpacks/pack/issues/1489
  new         Creates basic scaffolding of an extension.
  pull        Pull an extension from a registry and store it locally
  register    Register an extension to a registry
  yank        Yank an extension from a registry

We should probably make a separate issue for each one of these commands, as they could be implemented separately.

Edit: Made a separate issue (#1489) for pack extension package.

@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels Jun 23, 2022
@cmoulliard
Copy link

What is the purpose of this command ? Can you elaborate please ? @natalieparellano

@natalieparellano
Copy link
Member Author

Ah - this is to provide similar functionality to what you get with pack buildpack package (for distribution purposes). It is less important than #1468 but I added it for completeness.

@natalieparellano natalieparellano added status/blocked Issue or PR that is blocked. See comments. and removed status/triage Issue or PR that requires contributor attention. labels Jun 24, 2022
@natalieparellano
Copy link
Member Author

Blocking on buildpacks/rfcs#173 getting approved and merged.

@natalieparellano natalieparellano added the good first issue A good first issue to get started with. label Jun 24, 2022
@oovk
Copy link

oovk commented Jun 27, 2022

Hi @natalieparellano I'm new to this repo. Can you please guide me to appropriate code part? and a bit of explanation about the issue would be really helpful!

@natalieparellano
Copy link
Member Author

@oovk it would be awesome to get your help on this! At a high level, this is about creating a pack extension package command that is analogous to pack buildpack package, except for "extensions" - a new experimental CNB component described in buildpacks/rfcs#173.

From a pack perspective, extensions are very similar to buildpacks, except they have an extension.toml (instead of a buildpack.toml). The output of pack extension package should be either a .cnb file or an OCI image, just like pack buildpack package. A good place to start might be here.

How does that sound? Let us know if you'd like this issue assigned to you!

@natalieparellano natalieparellano changed the title pack should support pack extension package pack should support pack extension * commands Jul 22, 2022
@itsdarshankumar
Copy link
Contributor

@natalieparellano can you please assign me issue #1470 or #1489 or similar to pack extension, i'm guessing they would be a good first issue for me

@itsdarshankumar
Copy link
Contributor

@natalieparellano can you please open up an issue for the implementation of inspect command, I'll now try my hands to implement it

@natalieparellano
Copy link
Member Author

Reopening as we now have --help but still need:

pack extension package
pack extension new

(We can skip the registry stuff for now - that requires further thought)

@natalieparellano
Copy link
Member Author

pack extension package was implemented in #1635

pack extension new can be tracked in #1636

Closing this meta issue in favor of the individual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good first issue to get started with. status/blocked Issue or PR that is blocked. See comments. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants