-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Build Acceptance Tests #1498
Draft
jromero
wants to merge
18
commits into
main
Choose a base branch
from
chore/acceptance-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
github-actions
bot
added
type/chore
Issue that requests non-user facing changes.
type/enhancement
Issue that requests a new feature or improvement.
labels
Aug 11, 2022
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
…e tests in sequence Signed-off-by: Javier Romero <root@jromero.codes>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
+ Coverage 81.13% 81.26% +0.14%
==========================================
Files 155 154 -1
Lines 10084 10021 -63
==========================================
- Hits 8181 8143 -38
+ Misses 1420 1397 -23
+ Partials 483 481 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/chore
Issue that requests non-user facing changes.
type/enhancement
Issue that requests a new feature or improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this set of work is to minimize the level of effort for contributors when adding new build-related features to
pack
while maintaining the same level of quality via acceptance tests.TODO
make acceptance
make acceptance-all
Output
Before
After
Documentation
Related
Resolves #___