-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated node version for github actions #1562
Conversation
70b1251
to
64d0b7a
Compare
Hi @samj1912 Can you please review this one as well? |
@SaumyaBhushan did you have a chance to test this and see if it works with node16? |
No I have not @samj1912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: SaumyaBhushan <saumya@knoldus.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 80.52% 81.14% +0.63%
==========================================
Files 163 156 -7
Lines 10740 10362 -378
==========================================
- Hits 8647 8407 -240
+ Misses 1576 1458 -118
+ Partials 517 497 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help!
Validated here: #1561 (comment)
Hi @dfreilich Are we planning to merge this one or do we need to change something here ? |
The previous CI failures appear to be flakes. Hopefully this goes green with the latest updates from |
Signed-off-by: SaumyaBhushan saumya@knoldus.com
Summary
updated node version for github actions
Output
Before
Node 12
After
Node 16
Documentation
Related
#1561
Resolves #1561