-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-0078 Support for --pre-buildpack and --post-buildpack #1621
Conversation
d1a5a7a
to
043f6db
Compare
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
043f6db
to
d67ab0a
Compare
if (len(order) == 0 || len(order[0].Group) == 0) && len(builderOrder) > 0 { | ||
preBuildpacks := opts.PreBuildpacks | ||
postBuildpacks := opts.PostBuildpacks | ||
if len(preBuildpacks) == 0 && len(opts.ProjectDescriptor.Build.Pre.Buildpacks) > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm almost surely just missing something but it's not obvious to me why the len(preBuildpacks)==0
check is important -- we wouldn't want to copy in the buildpacks from the projectdescriptor regardless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, that's a good question... if we should merge --pre-buildpacks
with opts.ProjectDescriptor.Build.Pre.Buildpacks
. Or have it override (as it's written now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning toward override because i'm not sure it's obvious which would come first in the order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think merging stuff gets messy, so I'm 👍 on overriding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool cool, thanks :)
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
==========================================
+ Coverage 79.56% 79.56% +0.01%
==========================================
Files 163 163
Lines 10661 10735 +74
==========================================
+ Hits 8481 8540 +59
- Misses 1668 1678 +10
- Partials 512 517 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
b8edf0c
to
04fb5a7
Compare
Summary
Implements RFC-0078
Fixes #1099
Output
Before
N/A
After
or
or
Documentation
Related
Resolves #___