Fix log message when buildpack doesn't satisfy target constraints for builder #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… builder Signed-off-by: Natalie Arellano <narellano@vmware.com>
github-actions
bot
added
the
type/enhancement
Closed
5 tasks
|
I'll probably need to approve again after you fix thx pipeline |
jkutner
approved these changes
Jun 20, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Ah well, I fixed the test expectation. This should go green now :) |
jjbustamante
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To recreate:
pack builder create test-log --config ./some-builder.tomlWhere
some-builder.tomlreference base images that are linux/amd64 and also references a buildpack that has[[targets]]\n os = "windows"in buildpack.toml.For the lifecycle we decided that printing as JSON would be clearer than any custom
String()method we could provide.Before
Error message looks like:
ERROR: validating buildpacks: buildpack samples/hello-extensions@0.0.1 does not support target: (linux amd64, @)After
Error message looks like:
ERROR: validating buildpacks: unable to satisfy target os/arch constraints; build image: {"os":"linux","arch":"amd64","distribution":{}}, buildpack samples/hello-extensions@0.0.1: [{"os":"windows","arch":""}]