Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of the detect command #2072

Closed
wants to merge 4 commits into from

Conversation

rashadism
Copy link

@rashadism rashadism commented Feb 18, 2024

Summary

Added a new command detect which would run the analyze binary followed by the detect binary from the lifecycle against your source code. Corresponding RFC at #308

Output

Outputs the selected group of buildpacks from the detect phase.

Before

After

Documentation

  • Should this change be documented?
    • Yes
    • No

Related

Resolves #___

@rashadism rashadism requested review from a team as code owners February 18, 2024 16:46
@github-actions github-actions bot added this to the 0.34.0 milestone Feb 18, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 233 lines in your changes are missing coverage. Please review.

Comparison is base (06e3112) 79.68% compared to head (af2e9ba) 78.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
- Coverage   79.68%   78.30%   -1.37%     
==========================================
  Files         176      178       +2     
  Lines       13246    13479     +233     
==========================================
  Hits        10554    10554              
- Misses       2022     2255     +233     
  Partials      670      670              
Flag Coverage Δ
os_linux 77.25% <0.00%> (-1.36%) ⬇️
os_macos 74.99% <0.00%> (-1.32%) ⬇️
os_windows 77.70% <0.00%> (-1.36%) ⬇️
unit 78.30% <0.00%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.35.0 Mar 8, 2024
@github-actions github-actions bot modified the milestones: 0.35.0, 0.34.0 Apr 18, 2024
@rashadism rashadism closed this Apr 18, 2024
@rashadism rashadism deleted the detectcmd branch April 18, 2024 07:25
@jjbustamante jjbustamante removed this from the 0.34.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants