-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the multi-platform support for builders and buildpack packages RFC 0128 #2086
Implementation of the multi-platform support for builders and buildpack packages RFC 0128 #2086
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
- Coverage 79.69% 75.98% -3.71%
==========================================
Files 176 192 +16
Lines 13254 14038 +784
==========================================
+ Hits 10562 10665 +103
- Misses 2022 2676 +654
- Partials 670 697 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hello 👋
from We had success running, from the ~/buildpack directory, using:
with a layout similar to this:
and we successfully obtained a multi arch image:
Yay 🎉 But then, we tried running it from elsewhere, using such a
and this did not produce an expected dual arch image:
Is it either a bug or do we do something wrong? |
Yeah, it is a bug, I noticed that when preparing my script for the KubeCon demo, I haven't took a look yet, sorry! keep testing it running from the buildpack/builder folder |
We're just going to document all of our issues as we encounter them. Using the same
We'd expect the manifest list to only contain the latest entries |
Thank you @sophiewigmore ! Yes I noticed the duplication too! that's part of the |
hello @jjbustamante ! any updates since Kubecon? |
Hi @anthonydahanne, some updates:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still going through it, but leaving a few comments in the meantime :)
c7b1521
to
9c8a2ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjbustamante alrighty I've finally looked through all the files. I left a few comments. It mostly looks sensible, though we'll definitely want more tests and probably an acceptance test or two. LMK if I can be of any help at all.
25e37f4
to
cb4b368
Compare
…fecycle Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
cfdcaf6
to
6fa0cbc
Compare
6fa0cbc
to
dad414b
Compare
…rwin Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
7cca91b
to
68d1efa
Compare
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
166c3d8
to
0ca0429
Compare
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
0ca0429
to
03a0d8f
Compare
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
082c69e
to
ae8e20b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for all of your hard work @jjbustamante ❤️
Summary
The purpose of this PR is to implement the RFC 0128.
It adds the capability to the
pack buildpack package
andpack builder create
to generate multi-platform OCI images and create an image index to combine them.A draft version of this PR was demo during KubeCon EU 24. See the recording here
Output
Before
After
Targets
entries in thebuildpack.toml
orpackage.toml
files.Check the document mentioned above, it has a detailed output
Documentation
Related
Resolves #1459
Resolves #2079