Add .sha256 files to releases #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
suggested changes
Aug 25, 2020
dfreilich
force-pushed
the
add-checksums
branch
2 times, most recently
from
c8bdfa9
to
c320afa
Compare
|
@jromero thanks for pointing that out, I rushed this and totally missed that. I switched it to this action, since the default github one isn't being maintained (actions/upload-release-asset#58), and therefore hasn't implemented a
Testing it out on my fork, I was able to successfully generate a release with the .sha256 files. |
Signed-off-by: David Freilich <dfreilich@vmware.com>
* Allows for using a glob for files, ensuring all are uploaded easily * Rename the zipped dirs to reflect what we want name to be. Signed-off-by: David Freilich <dfreilich@vmware.com>
dfreilich
force-pushed
the
add-checksums
branch
from
8e2abc0
to
ae0ee46
Compare
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 73.52% 77.48% +3.96%
==========================================
Files 75 81 +6
Lines 5135 4657 -478
==========================================
- Hits 3775 3608 -167
+ Misses 1043 726 -317
- Partials 317 323 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Freilich dfreilich@vmware.com
Summary
Add .sha256 files to releases. It worked successfully over here
Documentation
Related
Related to, but doesn't resolve #799 (still need to add pgp signatures)