Remove references to custom env templating #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is a breaking change, we decided to do this in a separate (yet to be created) RFC. Created issue: #258 In addition to the changes described originally in 0093 we'd like some way of versioning the launcher interface, to avoid surprising end-users. Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
natalieparellano
commented
Dec 2, 2022
| @@ -295,7 +232,6 @@ we would convert it to the following in `metadata.toml` | |||
| type = "hi" | |||
| command = ["echo", "hello", "world"] | |||
| args = [] | |||
| api = "0.5" | |||
There was a problem hiding this comment.
This ended up not being necessary, as the buildpack-id is actually a part of this table.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Thank you for updating this RFC - it referring to the env interpolation feature caused me a bit of confusion a few days ago, when I was trying to use the feature (since the rest of this RFC was implemented, making me think env var interpolation was too). |
sambhav
approved these changes
Dec 15, 2022
jjbustamante
pushed a commit
that referenced
this pull request
Feb 13, 2023
Remove references to custom env templating Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is a breaking change, we decided to do this in a separate (yet to be created) RFC. Created issue: #258 In addition to the changes described originally in 0093 we'd like some way of versioning the launcher interface,
to avoid surprising end-users.
Signed-off-by: Natalie Arellano narellano@vmware.com