Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multi-platform artifacts when creating builders and buildpack package #295

Merged
merged 17 commits into from
Apr 10, 2024
Merged

Support for multi-platform artifacts when creating builders and buildpack package #295

merged 17 commits into from
Apr 10, 2024

Commits on Mar 27, 2024

  1. Initial version 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    88c024f View commit details
    Browse the repository at this point in the history

  2. Change flag --platform to use --target, and adding a field to overrid… 

    …e the path for binaries in buildpack.toml

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    af7811b View commit details
    Browse the repository at this point in the history

  3. fixing some feedback from review, removing --multi-arch flag 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d4ba0ba View commit details
    Browse the repository at this point in the history

  4. removing multi-arch flag 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    614052b View commit details
    Browse the repository at this point in the history

  5. fixing some format with the formulas 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7d017d8 View commit details
    Browse the repository at this point in the history

  6. updating shared folders definition 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    cf6879e View commit details
    Browse the repository at this point in the history

  7. fixing the shared layers concept, because we can't do it based on the… 

    … distribution spec

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    93a2d3a View commit details
    Browse the repository at this point in the history

  8. adding some overriding rules 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    515f41a View commit details
    Browse the repository at this point in the history

  9. Update text/0000-multiarch-builders-and-package.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante @natalieparellano
    jjbustamante and natalieparellano committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    62847fd View commit details
    Browse the repository at this point in the history

  10. Update text/0000-multiarch-builders-and-package.md 

    Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante @natalieparellano
    jjbustamante and natalieparellano committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    075b11c View commit details
    Browse the repository at this point in the history

  11. adding some more feedback from review 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fbdd181 View commit details
    Browse the repository at this point in the history

  12. Removing the shared files complexity 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    05a4383 View commit details
    Browse the repository at this point in the history

  13. Fixing some format issues 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f064a78 View commit details
    Browse the repository at this point in the history

  14. removing mandataroy comment from packaga.toml 

    Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    335a57d View commit details
    Browse the repository at this point in the history

  15. removing package.toml to be mandatory, it is not! and adding some log… 

    …ic when exporting multi-arch buildpack packages as files

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante
    jjbustamante committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    14e3265 View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from code review 

    Co-authored-by: Rune Soerensen <runesoerensen@gmail.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante @runesoerensen
    jjbustamante and runesoerensen committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0f53031 View commit details
    Browse the repository at this point in the history

  17. Apply suggestions from code review 

    Co-authored-by: Rune Soerensen <runesoerensen@gmail.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
    @jjbustamante @runesoerensen
    jjbustamante and runesoerensen committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    abd3ba2 View commit details
    Browse the repository at this point in the history