RFC: add opentelemetry support #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
…microsoft.com> Signed-off-by: qiaoleiatms <qiaolei@microsoft.com>
Signed-off-by: qiaoleiatms <qiaolei@microsoft.com>
qiaoleiatms
force-pushed
the
support-opentelemetry-metrics
branch
from
1095599
to
a1fda76
Compare
|
There seems to overlap between this and #299. Do you want to work with the author @joshwlewis ? |
|
@qiaoleiatms @joshwlewis any further thoughts here? |
|
@qiaoleiatms I've updated #299. It does include some reasoning as to why I prefer it over this approach. I'd love to hear your thoughts. It might be easy to chat in slack by the way. You can find me in the slack linked on the community page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a discussion here:
buildpacks/lifecycle#1208