Update RFC 0096 (stacks removal) to match what landed in the spec #310
Conversation
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
There was a problem hiding this comment.
@edmorley thanks for this. Could you add the amended metadata at the bottom?
<!--
## Amended
### Meta
[meta-1]: #meta-1
- Name: (fill in the amendment name: Variable Rename)
- Start Date: (fill in today's date: YYYY-MM-DD)
- Author(s): (Github usernames)
- Amendment Pull Request: (leave blank)
### Summary
A brief description of the changes.
### Motivation
Why was this amendment necessary?
--->
|
@natalieparellano Sure - added now :-) |
|
Oh I also found one more change that was made when the spec was updated, that I've backported now:
(xref buildpacks/spec#401) |
edmorley
changed the title
To give some more context here - one of the reasons I look at the RFCs when implementing, is that they are quite prominently linked from the spec GitHub release entries: |
edmorley
force-pushed
the
patch-2
branch
2 times, most recently
from
194cfc7
to
6143320
Compare
|
(Me using the GitHub rebase button broke the GPG verification status of the commits, so I've squashed and manually pushed instead) |
A few changes were made to what was in the RFC when it came to update the spec. This backports those changes to the RFC to try and prevent user confusion if they use the RFC as a means of learning about targets when implementing. Specifically: - The `io.buildpacks.distribution.*` Docker labels were renamed to `io.buildpacks.base.distro.*`. - The `io.buildpacks.id` Docker label was renamed to `io.buildpacks.base.id`. - The `buildpack.toml` table `[[targets.distributions]]` was renamed to `[[targets.distros]]` and the `versions` field within it renamed to `version` (along with its type changing from an array to a string). See: https://github.com/buildpacks/spec/blob/platform/0.13/platform.md#target-data Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
|
It's spreading! 😆 |
edmorley
changed the title
|
Please can I have review/merge? :-) |
A few changes were made to what was in RFC96 when it came to update the spec:
buildpacks/spec#365
This backports those changes to the RFC to try and prevent user confusion if they use the RFC as a means of learning about targets when implementing.
Specifically:
io.buildpacks.distribution.*Docker labels were renamed toio.buildpacks.base.distro.*.io.buildpacks.idDocker label was renamed toio.buildpacks.base.id.buildpack.tomltable[[targets.distributions]]was renamed to[[targets.distros]]and theversionsfield within it renamed toversion(along with its type changing from an array to a string).See:
https://github.com/buildpacks/spec/blob/platform/0.13/platform.md#target-data