Change defaults that depending on the working dir #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been a frequent request of the lifecycle. Default file paths relative to the working dir are confusing because we provide no guidance on what the working directory should be when the platform executes the lifecycle. Making defaults relative to layers is better because, when phases are executed in separate containers these files should exist on a volume so they may be passed between phases. Right now if a user changes the layers dir they must also change the path of group.toml, plan.toml, etc so that they files are passed between phases. This is annoying. If the defaults are relative to <layers>, changing the layers dir "just works" without requiring a variety of other flags. Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
commented
Jul 31, 2020
| | `<group>` | `CNB_GROUP_PATH` | `<layers>/group.toml` | Path to output group definition | ||
| | `<layers>` | `CNB_LAYERS_DIR` | `/layers` | Path to layers directory | ||
| | `<log-level>` | `CNB_LOG_LEVEL` | `info` | Log Level | ||
| | `<order>` | `CNB_ORDER_PATH` | `/cnb/order.toml` | Path to order definition (see [`order.toml`](#ordertoml-toml)) |
There was a problem hiding this comment.
This one was just a mistake in the platform rewrite.
nebhale
approved these changes
Aug 3, 2020
jkutner
approved these changes
Aug 3, 2020
|
thanks! i ran into this just last week. |
|
Yeah, I also found this annoying. I assume for the most part this won't break any existing users using lifecycle. Mostly would be people doing one off / tty of lifecycle? |
hone
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a frequent request of the lifecycle. Default file paths relative to the working dir are confusing because we provide no guidance on what the working directory should be when the platform executes the lifecycle. Making defaults relative to layers is better because, when phases are executed in separate containers these files should exist on a volume so they may be passed between phases. Right now if a user changes the layers dir they must also change the path of group.toml, plan.toml, etc so that they files are passed between phases. This is annoying. If the defaults are relative to , changing the layers dir "just works" without requiring a variety of other flags.
Signed-off-by: Emily Casey ecasey@vmware.com