Assume web is the default for older buildpacks #204
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
assume-web-default
branch
from
8f57679
to
ff640ab
Compare
|
@yaelharel I took a stab at it - do you mind taking a look at it? Note that these are only the platform changes... |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
| @@ -893,6 +899,8 @@ Where: | |||
|
|
|||
| #### `metadata.toml` (TOML) | |||
| ```toml | |||
| buildpack-default-process-type = "<process type>" | |||
There was a problem hiding this comment.
Do we need the "buildpack-" prefix here? Should we add a top-level key?
There was a problem hiding this comment.
We wanted buildpack- to differentiate between the buildpack-provided default and user-provided default (via the -process-type flag). We thought it would be confusing if the app had default process type some-user-type and metadata.toml contained default-process-type = some-buildpack-type. An alternative that we considered was deleting this key from metadata.toml prior to export, so that it is only used to pass information between phases.
As for whether it should be a top-level key, I'm not sure... we thought about adding default = <true or false> under each buildpack but then we also thought it would be confusing given that multiple buildpacks can each contribute a default and it wouldn't be obvious to the reader of this file that "last wins".
cc @yaelharel please add if I missed anything!
Fixes #160
Signed-off-by: Natalie Arellano narellano@vmware.com