Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group additions to Builder order #233

Merged
merged 10 commits into from
Aug 25, 2021

Conversation

jkutner
Copy link
Member

@jkutner jkutner commented Jun 25, 2021

Spec for RFC-0078

Fixes #195

I didn't add an example because this feature isn't compatible with other elements already used in the existing example.

@jkutner jkutner requested a review from a team as a code owner June 25, 2021 19:30
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with typographical error edit.

extensions/project-descriptor.md Outdated Show resolved Hide resolved
extensions/project-descriptor.md Outdated Show resolved Hide resolved
jkutner and others added 2 commits June 25, 2021 21:00
Signed-off-by: Joe Kutner <jpkutner@gmail.com>

Co-authored-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>

Co-authored-by: Javier Romero <rjavier@vmware.com>
@ekcasey ekcasey added this to the Project Descriptor 0.2 milestone Jun 30, 2021
Signed-off-by: Joe Kutner <jpkutner@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
@ekcasey ekcasey requested review from nebhale and sclevine July 7, 2021 18:08
Signed-off-by: Joe Kutner <jpkutner@gmail.com>

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
@hone
Copy link
Member

hone commented Aug 11, 2021

@buildpacks/core-team please re-review.

@hone hone requested review from jromero and ekcasey August 11, 2021 18:14
extensions/project-descriptor.md Outdated Show resolved Hide resolved
extensions/project-descriptor.md Outdated Show resolved Hide resolved
extensions/project-descriptor.md Outdated Show resolved Hide resolved
extensions/project-descriptor.md Outdated Show resolved Hide resolved
Signed-off-by: Joe Kutner <jpkutner@gmail.com>

Co-authored-by: Javier Romero <rjavier@vmware.com>
jkutner and others added 2 commits August 25, 2021 11:01
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>

Co-authored-by: Terence Lee <hone02@gmail.com>
@ekcasey ekcasey merged commit b558933 into extensions/project-descriptor/0.2 Aug 25, 2021
@ekcasey ekcasey deleted the jkutner/rfc-0078 branch August 25, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants