Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layer examples #235

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Fix layer examples #235

merged 2 commits into from
Jul 7, 2021

Conversation

sclevine
Copy link
Member

Fixes several issues with the examples:

  • First example has cache = true, but also applies to cache = false
  • Second example has build = true, but also applies to build = false
  • Third example does not clearly specify how layers are used

@sclevine
Fix layer examples
65b4308 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine sclevine requested a review from a team as a code owner June 28, 2021 05:54
jkutner
jkutner reviewed Jun 28, 2021
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@sclevine @jkutner
Fix typo
873a537 
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Joe Kutner <jpkutner@gmail.com>
@ekcasey ekcasey changed the base branch from main to buildpack/0.7 June 30, 2021 22:19
@ekcasey ekcasey added this to the Buildpack 0.7 milestone Jun 30, 2021
@ekcasey ekcasey merged commit f93ab0f into buildpack/0.7 Jul 7, 2021
@ekcasey ekcasey deleted the fix-layer-examples branch July 7, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

@hone hone hone approved these changes

@jabrown85 jabrown85 jabrown85 approved these changes

@ekcasey ekcasey ekcasey approved these changes

Assignees
No one assigned
Labels
api/buildpack
Projects
None yet
Milestone
Buildpack 0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@sclevine @jkutner @hone @jabrown85 @ekcasey