Clarify buildpack API must be u64 numbers #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the spec doesn't state what <major> and <minor> are expected to be. I am proposing that we scope them to only contain numbers which seems to be what the lifecycle is already expecting: https://github.com/buildpacks/lifecycle/blob/a7428a55c2a14d8a37e84285b95dc63192e3264e/api/version.go#L13-L16 Going beyond specifying they should be numbers, I also want to specify "unsigned 64 bit" integer which further bounds api versions to be greater than (or equal to) zero and less than (or equal to) 1,844,674,4073,709,551,615. Signed-off-by: Richard Schneeman <rschneeman@salesforce.com>
|
Exactly the same as #263 but without rebasing in main. |
|
Thanks @schneems ! |
hone
approved these changes
Oct 27, 2021
jromero
approved these changes
Oct 27, 2021
jkutner
approved these changes
Oct 29, 2021
Malax
added a commit
to heroku/libcnb.rs
that referenced
this pull request
Aug 25, 2022
This was clarified in the upstream buildpack API 0.7: buildpacks/spec#265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the spec doesn't state what and are expected to be.
I am proposing that we scope them to only contain numbers which seems to be what the lifecycle is already expecting:
https://github.com/buildpacks/lifecycle/blob/a7428a55c2a14d8a37e84285b95dc63192e3264e/api/version.go#L13-L16
Going beyond specifying they should be numbers, I also want to specify "unsigned 64 bit" integer which further bounds api versions to be greater than (or equal to) zero and less than (or equal to) 1,844,674,4073,709,551,615.