Clarify what -skip-restore means #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Should we just roll this into #278 ? |
hone
approved these changes
Dec 15, 2021
hone
approved these changes
Dec 15, 2021
jkutner
approved these changes
Jan 5, 2022
nebhale
approved these changes
Jan 5, 2022
ekcasey
reviewed
Jan 13, 2022
| | `<tag>...` | | | Additional tag to apply to exported image | ||
|
|
||
| - **If** `<skip-restore>` is `true` the `creator` SHALL skip layer analysis and skip the entire Restore phase. | ||
| - **If** `<skip-restore>` is `true` the `creator` SHALL skip sbom layer restoration and skip the entire Restore phase. |
There was a problem hiding this comment.
For me at least, these clarifications generated additional confusion. I had to look at the implementation to see that sbom layer is restored to filesystem and then deleted in order to understand what was meant by "sbom layer restoration".
Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Emily Casey <ecasey@vmware.com>
ekcasey
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #278