Add sbom as a reserved buildpack ID #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
hone
approved these changes
Dec 15, 2021
hone
approved these changes
Dec 15, 2021
jkutner
approved these changes
Jan 5, 2022
nebhale
approved these changes
Jan 5, 2022
ekcasey
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Makes sense.
If we required the buildpack ID to be in the format <namespace>/<name> (like the registry does) we wouldn't need this list. But I don't remember why we didn't spec that requirement previously, and I wouldn't want that conversation to prevent us from adding this quick fix.
| @@ -1060,7 +1060,7 @@ Buildpack authors MUST choose a globally unique ID, for example: "io.buildpacks. | |||
|
|
|||
| *Key: `id = "<buildpack ID>"`* | |||
| - MUST only contain numbers, letters, and the characters `.`, `/`, and `-`. | |||
| - MUST NOT be `config` or `app`. | |||
| - MUST NOT be `config`, `app`, or `sbom`. | |||
There was a problem hiding this comment.
Do we actually need to reserve app anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technically should have gone into
buildpack/0.8. Because we are putting sbom files in/layers/sbom,sbomis now a reserved buildpack ID.