-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation path for buildpacks using the legacy BOM format. #286
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @natalieparellano ! I think this is the right path forward.
Assuming this change is approved, we have two paths forward for the implementation: (1) Ship a lifecycle patch (v0.13.3), then (at some later date) ship buildpack/0.8 - this would mean that the migration path outlined here also applies to buildpack/0.7
(2) Ship buildpack/0.8 with this change, then ship a lifecycle minor (v0.14.0) - this would mean that buildpack/0.7 only allows the new bom format, whereas buildpack/0.8 allows both old and new
Edit: you may use emojis to express preference for option 1 (🎉 ) vs option 2 (❤️ ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for leading the charge on this! I'm glad we're adding more things into this part of the file.
I'm not going to block the path that everyone seems to want here since there's a real problem that is hurting customers. That being said, it feels like we're getting by on a technicality here. I ranted at @jromero during OH yesterday on this topic, but if we're having such a hard time working with our spec process and how it's stuck b/c it's frozen, maybe it's time to revisit that line in the sand. Just to be concrete here, we're adding a Buildpack API 0.7
deprecation in Buildpack API 0.8
release. Is it worth talking about having "patch" releases of the Buildpack API?
Signed-off-by: Natalie Arellano <narellano@vmware.com>
See buildpacks/spec#286 - this was patched in a newer lifecycle, but is missing in the POC Signed-off-by: Natalie Arellano <narellano@vmware.com>
When we released the new SBOM, we created the following problem:
This PR proposes that buildpacks should be able to output both the old and the new BOM formats. Then older platforms will still have a BOM in the label, while newer platforms will have both.