Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process specific working directory #289

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Process specific working directory #289

merged 5 commits into from
Mar 9, 2022

Conversation

natalieparellano
Copy link
Member

Resolves #212

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner January 27, 2022 16:31
@hone
Copy link
Member

hone commented Feb 2, 2022

nit: should we switch over to just using 1. when doing numbered lists?

buildpack.md Outdated Show resolved Hide resolved
…le.d

Signed-off-by: Natalie Arellano <narellano@vmware.com>

3. If using an execution strategy involving a shell, the lifecycle MUST source [†](README.md#linux-only)`<app>/.profile` or [‡](README.md#windows-only)`<app>/.profile.bat` if it is present.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated in the line above.

buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
natalieparellano and others added 2 commits February 24, 2022 16:19
Signed-off-by: Natalie Arellano <narellano@vmware.com>

Co-authored-by: Emily Casey <ecasey@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

@ekcasey could you double check 0ecb2fe ?

buildpack.md Outdated Show resolved Hide resolved
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@hone
Copy link
Member

hone commented Mar 9, 2022

@jkutner Joe said I can approve this on his behalf.

@hone
Copy link
Member

hone commented Mar 9, 2022

@jkutner Joe said I can approved this on his behalf.

@ekcasey ekcasey merged commit 2437d7b into buildpack/0.8 Mar 9, 2022
@ekcasey ekcasey deleted the proc-work-dir branch March 9, 2022 19:14
Copy link
Member

@sclevine sclevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants