Add terminology section to the buildpack spec #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
This was referenced Mar 25, 2022
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Moving to buildpack/0.9 - a branch needs to be created |
nebhale
approved these changes
Mar 30, 2022
hone
reviewed
Apr 6, 2022
hone
reviewed
Apr 6, 2022
hone
reviewed
Apr 6, 2022
Signed-off-by: Natalie Arellano <narellano@vmware.com>
| @@ -91,6 +80,54 @@ Buildpack API versions: | |||
| - `<major>` and `<minor>` MUST only contain numbers (unsigned 64 bit integer) | |||
| - When `<major>` is greater than `0` increments to `<minor>` SHALL exclusively indicate additive changes | |||
|
|
|||
| ## Terminology | |||
|
|
|||
| ### CNB Terminology | |||
There was a problem hiding this comment.
Feedback from 4/21 Working Group: (if possible, without making each term its own section) we should link back to this section as much as is practical.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
|
||
| A buildpack descriptor that specifies `stacks` MUST describe a buildpack that implements the [Buildpack Interface](#buildpack-interface). |
There was a problem hiding this comment.
I don't really know what the latter half of this sentence is for
| @@ -1097,9 +1130,7 @@ Each stack in `stacks` either: | |||
| - `id` MUST be set to the special value `"*"`. | |||
| - `mixins` MUST be empty. | |||
|
|
|||
| #### Order Buildpacks | |||
|
|
|||
| A buildpack descriptor that specifies `order` MUST be [resolvable](#order-resolution) into an ordering of buildpacks that implement the [Buildpack Interface](#buildpack-interface). | |||
There was a problem hiding this comment.
Moved to terminology
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
|
||
| The resolution process MUST follow this pattern: | ||
|
|
||
| Where: | ||
| - O and P are buildpack orders. | ||
| - A through H are buildpack implementations. | ||
| - A through H are component buildpacks. |
There was a problem hiding this comment.
I think this is correct. But I'm a bit less sure of myself here.
|
@buildpacks/buildpack-authors-tooling-maintainers @buildpacks/implementation-maintainers I think this is ready for another review |
jkutner
approved these changes
Jun 26, 2022
samj1912
approved these changes
Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #145