-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terminology section to the buildpack spec #300
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Moving to buildpack/0.9 - a branch needs to be created |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@@ -91,6 +80,54 @@ Buildpack API versions: | |||
- `<major>` and `<minor>` MUST only contain numbers (unsigned 64 bit integer) | |||
- When `<major>` is greater than `0` increments to `<minor>` SHALL exclusively indicate additive changes | |||
|
|||
## Terminology | |||
|
|||
### CNB Terminology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from 4/21 Working Group: (if possible, without making each term its own section) we should link back to this section as much as is practical.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
||
A buildpack descriptor that specifies `stacks` MUST describe a buildpack that implements the [Buildpack Interface](#buildpack-interface). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know what the latter half of this sentence is for
@@ -1097,9 +1130,7 @@ Each stack in `stacks` either: | |||
- `id` MUST be set to the special value `"*"`. | |||
- `mixins` MUST be empty. | |||
|
|||
#### Order Buildpacks | |||
|
|||
A buildpack descriptor that specifies `order` MUST be [resolvable](#order-resolution) into an ordering of buildpacks that implement the [Buildpack Interface](#buildpack-interface). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to terminology
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
||
The resolution process MUST follow this pattern: | ||
|
||
Where: | ||
- O and P are buildpack orders. | ||
- A through H are buildpack implementations. | ||
- A through H are component buildpacks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct. But I'm a bit less sure of myself here.
@buildpacks/buildpack-authors-tooling-maintainers @buildpacks/implementation-maintainers I think this is ready for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I still feel a bit queasy about "component" buildpack as a term but I can't think of a good alternative.
Resolves #145