-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack removal: platform changes #335
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…atch buildpack spec Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
To note: if image extensions are used to switch the run image, whatever validations were already performed will need to be re-done by the exporter. This may affect how we choose to design the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel pretty good about this direction - hard to tell what rough edges may exist without doing the work.
Co-authored-by: Terence Lee <hone02@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
@hone would you mind taking another pass through the open convos? I think I addressed most of the stuff. The last open question for me is around |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
No description provided.