-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define CNB_BUILD_CONFIG_DIR behavior #345
Conversation
The `<...>` references must be wrapped with backticks, or they are not rendered at all, making the spec hard to follow. Example of the current broken rendering: > MUST be in form . or , where is equivalent to .0 Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Fix schema version markdown rendering in project-descriptor.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments in the Buildpacks API about sections that don't belong there. Separately we need to target the above changes in platform 0.11 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add something at or near https://github.com/buildpacks/spec/blob/main/platform.md#user-provided-variables describing (to the operator) how the env var files are supposed to work. Something like https://github.com/buildpacks/spec/blob/main/buildpack.md#environment-variable-modification-rules from the buildpack API, but tailored to the build config dir.
Related Slack conversation: https://cloud-native.slack.com/archives/C033DV9EBDF/p1672938165893439 I know this is late in the game, but to my eye changing the default behavior (when files are suffix-less) to Edit: concluded in Slack, |
I've not yet addressed this comment. Will do so when buildpacks/rfcs#271 lands, as that will confirm my understanding. |
RFC #109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
48194cd
to
2c5a805
Compare
@AidanDelaney were you planning to add:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to split this PR into platform and buildpack api changes and set the base branch to the relevant target apis.
I've split the buildpack.md changes out into #349 |
Describe how CNB_BUILD_CONFIG_DIR variables MUST be provided in the lifecycle execution environment and the suffixes that are allowed. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Revert changes to buildpack.md so that platform.md can be merged into appropriate branches. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
bcfcd28
to
4cff1db
Compare
This PR now only contains the changes to |
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
platform.md
Outdated
|
||
The platform MUST set operator-provided environment variables directly in the lifecycle execution environment. | ||
|
||
The `CNB_BUILD_CONFIG_DIR` directory follows the same convention as [Environment Variable Modification Rules](https://github.com/buildpacks/spec/blob/main/buildpack.md#environment-variable-modification-rules). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add that if no extension is provided, the default extension is .default
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
RFC #109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior.
Fixes #330
Signed-off-by: Aidan Delaney adelaney21@bloomberg.net